Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(*): replace BrowserFs for ZenFs #134

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

enddynayn
Copy link
Collaborator

@enddynayn enddynayn commented Jul 1, 2024

Update the project to use ZenFs instead of BrowserFs, as BrowserFs is now deprecated.

#127

Update the project to use ZenFs instead of BrowserFs,
as BrowserFs is now deprecated.

issue-127
@enddynayn enddynayn changed the title chore(*): replace browserfs for zenfs chore(*): replace BrowserFs for ZenFs Jul 1, 2024
Copy link
Collaborator

@saraswatpuneet saraswatpuneet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍🏽
🛥️

@enddynayn enddynayn merged commit 40357ad into main Jul 1, 2024
1 check passed
@wilwade wilwade deleted the chore/broswerfs-deprecated-issue-127 branch August 22, 2024 17:33
wilwade pushed a commit that referenced this pull request Sep 5, 2024
- Previous version of zenfs-core had an engine requirement of >=22 which
was higher than the engine requirement for this library (18.18.2) which
caused issues with installing the library using yarn. (Yarn seemed to
error on engine mismatch but trying it with npm just seemed to log a
warning)

# Problem

In release 1.8.0 the browserfs dependency was replaced with zenfs
(#134). This ^0.14.0 version has a engine requirement of 22, which has
caused issues when I've tried to install this package in a node 18
project. The engine requirement for this library is 18.18.2.

Solution
========
In the 0.15.1 release of `@zenfs/core` they've added a polyfill and
reduced the engine requirement to node 16.
https://github.com/zen-fs/core/releases/tag/v0.15.1

I've bumped the version all the way to ^0.16.0 in case there were other
fixes along the way. The rest of the changelogs can be seen:
https://github.com/zen-fs/core/releases

You can see in the `package-lock.json` that the engine requirement has
changed from 22 to 16.

## Change summary:

- Bump version of @zenfs/core to ^0.16.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants